Update chat's newEditSession command to take an input prompt#241796
Merged
roblourens merged 4 commits intomicrosoft:mainfrom Feb 27, 2025
Merged
Update chat's newEditSession command to take an input prompt#241796roblourens merged 4 commits intomicrosoft:mainfrom
newEditSession command to take an input prompt#241796roblourens merged 4 commits intomicrosoft:mainfrom
Conversation
roblourens
reviewed
Feb 26, 2025
src/vs/workbench/contrib/chat/browser/actions/chatClearActions.ts
Outdated
Show resolved
Hide resolved
roblourens
approved these changes
Feb 27, 2025
bpasero
approved these changes
Feb 27, 2025
bpasero
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For standard chat, there is a
workbench.action.chat.sendToNewChatcommand which takes an input value and automatically submits the value.However, that command doesn't exist for edit sessions. There is, however, already the
workbench.action.chat.newEditSessioncommand which will create a new, empty edit session. This PR extends that command to take 2 new optional arguments:agentMode- boolean to start the new session in agent mode or notinputValue- the prompt text to write and then submitThere were a lot of similar commands that I looked at for this PR, as well as just making a new command to only accept input text. I ended up going this route because the
newEditSessionlogic already had support for warning when overwriting an in-progress session and similar logic that would otherwise need to be duplicated.