Remove unnecessary classes from body#240633
Conversation
|
I am not convinced and know what kind of regressions this could cause. |
|
I guess it shouldn't cost a lot of regressions, because those classes are just redundant.. I think you have something like screenshot testing btw. |
There was a problem hiding this comment.
This change works based on the assumption that nothing is being added to the body element outside the monaco-workbench element, which I think is fair, anything else would probably be something we have to address (except for the splash screen).
However, in that case I would suggest to actually go back to how it was in 1b908ce and prefix more elements with .monaco-workbench to reflect this change.
The one thing I am uncertain about how to rescue though is this one:
vscode/src/vs/workbench/browser/media/style.css
Lines 48 to 50 in a948ee5
|
Adding As far as I understand this is just a workaround to fix the "scroll bounce". I guess |
This comment was marked as spam.
This comment was marked as spam.
@microsoft-github-policy-service agree |
5 participants
There is no need to add extra classes to the body, as these classes are specific to the editor area.
These classes apply fonts, but they apply them already at the line above to
mainContainer.Thus, they are already specified in the editor area and should not be applied to the body element.
And the only thing the monaco editor has outside of its scope is
monaco-parts-splash. And that's a loading screen with no text on it at all.