Add node as npm script runner (2nd)#240527
Merged
roblourens merged 11 commits intomicrosoft:mainfrom Feb 17, 2025
xymopen:main
Merged
Add node as npm script runner (2nd)#240527roblourens merged 11 commits intomicrosoft:mainfrom xymopen:main
roblourens merged 11 commits intomicrosoft:mainfrom
xymopen:main
Conversation
…sk` from `createTask`
Upstream reviewer is ok with current state
roblourens
approved these changes
Feb 12, 2025
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
This works for me now, thanks!
hediet
approved these changes
Feb 12, 2025
Contributor
Author
|
The checks seem to be frozen. Do we need to trigger another run? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2nd attempt to fixes #234468
The original PR suffers from a bug and has been reverted. This PR hopes to re-introduce this feature w/o the bug.