Fix behavior of terminal.integrated.confirmOnExit#240074
Merged
Tyriar merged 2 commits intomicrosoft:mainfrom Feb 13, 2025
Merged
Fix behavior of terminal.integrated.confirmOnExit#240074Tyriar merged 2 commits intomicrosoft:mainfrom
Tyriar merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
|
dmotte:pr-fix-terminal-confirmonexit |
|
pr-fix-terminal-confirmonexit |
|
A first-level heading |
Tyriar
approved these changes
Feb 13, 2025
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
This is great, thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you so much for providing this fantastic editor 🙂 I use it basically every day and it's amazing. Thank you all guys, and keep up the good work!
This PR fixes #235575.
Note that recently there was another PR (#236588) that was supposed to fix it, but actually it didn't, because now we have this:
The current PR should definitely fix this issue and avoid showing that popup message if there are no foreground terminals opened.
How to test the changes
You can just try to open a Python project in a VSCode editor with the Python extension installed. That extension spawns background terminals, and those currently trigger the popup message of the screenshot I put above (when
terminal.integrated.confirmOnExitis set toalways). With my changes, that shouldn't happen anymore.