Let the widgetactions debug UI reflect the state of a focused thread#23878
Merged
isidorn merged 1 commit intomicrosoft:masterfrom Apr 13, 2017
Merged
Let the widgetactions debug UI reflect the state of a focused thread#23878isidorn merged 1 commit intomicrosoft:masterfrom
isidorn merged 1 commit intomicrosoft:masterfrom
Conversation
|
@QwertyZW, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma and @joaomoreno to be potential reviewers. |
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
Contributor
Author
|
/cc @isidorn |
QwertyZW
changed the title
Collaborator
|
Thanks you for the great explanation and this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when we have a multi-threaded debugging session open, Continuing a thread and having another stopped thread get autofocused on the first thread's exit, or simply manually focusing a stopped thread, causes the widgetactions debugger UI to reflect the stale running state of the old thread instead of the stopped state of the newly focused thread, leaving no means to continue any of the stopped threads.
The commit here fixes that.
The editor and the debug viewlet appear to reflect the state of the debugger correctly.
If you require I can open an issue specific to this PR and attach a gif capture of my screen to better explain myself if that's required.