fix: file-found Badge vertical (#235159) #238757
fix: file-found Badge vertical (#235159) #238757benvillalobos merged 5 commits intomicrosoft:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a vertical alignment issue with badges in the file explorer (issue #235159). The changes ensure that count badges and icon labels are vertically centered by converting their display properties to flexbox with center alignment.
Key Changes:
- Updated badge display from
inline-blocktoinline-flexwith vertical centering - Applied flexbox vertical centering to icon label containers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/files/browser/media/explorerviewlet.css | Changed badge display to inline-flex with align-items: center for proper vertical alignment |
| src/vs/base/browser/ui/iconLabel/iconlabel.css | Added flexbox with vertical centering to icon name container |
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
benvillalobos
left a comment
benvillalobos
left a comment
There was a problem hiding this comment.
Outside of the requested change, this looks good!
benvillalobos
left a comment
benvillalobos
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Without Fix
With Fix
|
Thanks for the benvillalobos |
|
@ohah @benvillalobos this is not a good change, it causes #273052 Revert in #273068 |
|
@bpasero |
|
sorry, I checked it, and it turns out the issue was on my end. I’ll fix it and open a PR |
fixed #235159