Skip to content

Add noValuePreselect option to showInputBox#23827

Merged
jrieken merged 1 commit intomicrosoft:masterfrom
bschlenk:master
Apr 24, 2017
Merged

Add noValuePreselect option to showInputBox#23827
jrieken merged 1 commit intomicrosoft:masterfrom
bschlenk:master

Conversation

@bschlenk
Copy link
Contributor

@bschlenk bschlenk commented Apr 2, 2017

Allow extensions to decide if a value passed to vscode.window.showInputBox should start selected or not. Defaults to current behavior as to not break the experience of existing extensions.
Fixes #10582.

Allow extensions to decide if a value passed to
vscode.window.showInputBox should start selected or not. Defaults to
current behavior as to not break the experience of existing extensions.
Fixes #10582.
@mention-bot
Copy link

@bschlenk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma and @jrieken to be potential reviewers.

@msftclas
Copy link

msftclas commented Apr 2, 2017

@bschlenk,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

msftclas commented Apr 2, 2017

@bschlenk, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@jrieken
Copy link
Member

jrieken commented Apr 24, 2017

Thanks - I like. I'll merge tho make a another change to allow for a selection range, where undefined means everything, null nothing, and something like [0, 3] means select pre from preference etc

@jrieken jrieken merged commit f15d1e9 into microsoft:master Apr 24, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

quick-pick Quick-pick widget issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

showInputBox without highlighting default value

4 participants