Skip to content

fix: memory leak in settings indicators#236417

Merged
rzhao271 merged 4 commits intomicrosoft:mainfrom
SimonSiefke:fix/memory-leak-settings-indicators
Feb 21, 2025
Merged

fix: memory leak in settings indicators#236417
rzhao271 merged 4 commits intomicrosoft:mainfrom
SimonSiefke:fix/memory-leak-settings-indicators

Conversation

@SimonSiefke
Copy link
Contributor

This fixes a memory leak in the settings indicators.

Currently the function only clears the scopeOverridesIndicator in one if condition but not in others:

this.scopeOverridesIndicator.disposables.clear();

This means that the hover disposables added here

this.addHoverDisposables(this.scopeOverridesIndicator.disposables, this.scopeOverridesIndicator.element, showHover);

are not being cleared when calling updateScopeOverrides.

@rzhao271 rzhao271 added this to the January 2025 milestone Dec 17, 2024
@rzhao271 rzhao271 modified the milestones: January 2025, February 2025 Jan 24, 2025
@rzhao271 rzhao271 enabled auto-merge (squash) February 21, 2025 17:30
@rzhao271 rzhao271 merged commit 8841b8a into microsoft:main Feb 21, 2025
1 check passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants