Expose adjustWhitespace to TextEditor API.#234858
Merged
mjbvz merged 4 commits intomicrosoft:mainfrom Jan 31, 2025
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="Red Hat" |
- Disable adjustWhitespace in text edits with snippets so that code actions do not adjust snippet indentation by default - Adjust Emmet extension so that adjustWhitespace is enabled - Add testcase Signed-off-by: Roland Grunberg <[email protected]>
- Rename adjustWhitespace to keepWhitespace - Retain default behaviour of adjusting whitespace when keepWhitespace not defined Signed-off-by: Roland Grunberg <[email protected]>
Signed-off-by: Roland Grunberg <[email protected]>
- Restore original behaviour of bulk text edits adjusting whitespace - Add testcase Signed-off-by: Roland Grunberg <[email protected]>
jrieken
approved these changes
Jan 31, 2025
Member
|
Also asking @mjbvz to review because this adds new API without going the proposed api flow |
mjbvz
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on comments like microsoft/language-server-protocol#1892 (comment) , snippet edits should probably not be adjusting whitespace by default. For language support, once workspace edits have a property like,
vscode/src/vscode-dts/vscode.d.ts
Lines 4996 to 5001 in 275faf6
Before
insert-snippet-before.mp4
After
insert-snippet-after.mp4