Conversation
|
@cristianhosu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @egamma to be potential reviewers. |
|
@cristianhosu, It will cover your contributions to all Microsoft-managed open source projects. |
|
@cristianhosu, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
src/vs/code/electron-main/menus.ts
Outdated
| if (folders.length || files.length) { | ||
| openRecentMenu.append(__separator__()); | ||
| openRecentMenu.append(new MenuItem(this.likeAction('clearRecentlyOpened', { label: mnemonicLabel(nls.localize({ key: 'miClearItems', comment: ['&& denotes a mnemonic'] }, "&&Clear Items")), click: () => this.windowsService.clearRecentPathsList() }, false))); | ||
| //workbench.action.clearRecentItems |
There was a problem hiding this comment.
Sorry, i don't understand what you mean
There was a problem hiding this comment.
It means that you have left a commented out line //workbench.action.clearRecentItems, just remove it. 🙂
There was a problem hiding this comment.
Oh, i see. :) Sorry, forgot about that one.
| export class ClearRecentItemsAction extends Action { | ||
|
|
||
| public static ID = 'workbench.action.clearRecentItems'; | ||
| public static LABEL = nls.localize('clearRecentItems', "Clear Recent"); |
| registry.registerWorkbenchAction(new SyncActionDescriptor(OpenNextEditor, OpenNextEditor.ID, OpenNextEditor.LABEL, { primary: KeyMod.CtrlCmd | KeyCode.PageDown, mac: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.RightArrow, secondary: [KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.US_CLOSE_SQUARE_BRACKET] } }), 'View: Open Next Editor', category); | ||
| registry.registerWorkbenchAction(new SyncActionDescriptor(OpenPreviousEditor, OpenPreviousEditor.ID, OpenPreviousEditor.LABEL, { primary: KeyMod.CtrlCmd | KeyCode.PageUp, mac: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.LeftArrow, secondary: [KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.US_OPEN_SQUARE_BRACKET] } }), 'View: Open Previous Editor', category); | ||
| registry.registerWorkbenchAction(new SyncActionDescriptor(ReopenClosedEditorAction, ReopenClosedEditorAction.ID, ReopenClosedEditorAction.LABEL, { primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KEY_T }), 'View: Reopen Closed Editor', category); | ||
| registry.registerWorkbenchAction(new SyncActionDescriptor(ClearRecentItemsAction, ClearRecentItemsAction.ID, ClearRecentItemsAction.LABEL), 'View: Clear Items', category); |
|
@bpasero - can you please tell me why is the build failing? |
|
LGTM, I think the test failures are unrelated 👍 |
5 participants
Fixes #22768