Diff selection indicator line should use menu.separatorBackground instead of menu.border#228825
Merged
hediet merged 3 commits intomicrosoft:mainfrom Feb 13, 2025
Merged
Conversation
…tead of menu.border
Contributor
Author
|
@hediet - is this something you would be able to take a quick look at please :) |
Contributor
Author
|
@hediet - friendly ping on this :) |
hediet
approved these changes
Feb 7, 2025
Member
|
Thanks! |
Tyriar
approved these changes
Feb 7, 2025
Contributor
Author
hediet
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #228819
Currently the gutter icon background that shows the area of effect of a selection uses
menu.border. The problem with this is that there is no default value for this and it is not defined in many themes, including almost all the themes that are bundled with VS Code.Instead, using
menu.separatorBackground, which does have a default value, will ensure that this indicator is visible across most themes.