fix: cannot display MAKR Underlined in minimap #226116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackHole1
force-pushed
the
fix-minimap-underlined
branch
from
fff2192 to
3d78bfc
Compare
Fixed: microsoft#226114 After testing, there are no issues in Firefox, but in Chrome, lines with a lineWidth less than 0.3 will not be displayed. Some lines won't show if it is less than 0.4. It will only display normally if it is greater than or equal to 0.4. Codepen Test: https://codepen.io/blackhole1/pen/QWXmGYB Signed-off-by: Kevin Cui <[email protected]>
BlackHole1
force-pushed
the
fix-minimap-underlined
branch
from
3d78bfc to
73c788a
Compare
Contributor
Author
|
Friendly bump on this @alexdima |
alexdima
approved these changes
Jul 14, 2025
rzhao271
approved these changes
Jul 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #226114
After testing, there are no issues in Firefox, but in Chrome, lines with a lineWidth less than 0.3 will not be displayed. Some lines won't show if it is less than 0.4. It will only display normally if it is greater than or equal to 0.4.
Codepen Test: https://codepen.io/blackhole1/pen/QWXmGYB
Related PR: #190759
Related Contributor: @dgileadi