Skip to content

Support terminal shell args as string#22565

Merged
Tyriar merged 2 commits intomasterfrom
tyriar/19078
Mar 14, 2017
Merged

Support terminal shell args as string#22565
Tyriar merged 2 commits intomasterfrom
tyriar/19078

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 13, 2017

Fixes #19078

@Tyriar Tyriar added this to the March 2017 milestone Mar 13, 2017
@Tyriar Tyriar self-assigned this Mar 13, 2017
(this.terminalService.configHelper as TerminalConfigHelper).mergeDefaultShellPathAndArgs(shellLaunchConfig);
}
let shellArgs = shellLaunchConfig.args.slice(0);
let shellArgs = <string[]>shellLaunchConfig.args.slice(0);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weinand FYI IShellLaunchConfig can now have args as a string to support @dbaeumer's use case of needed to use a pre-escaped set of arguments. I needed to make this change which I believe shouldn't cause any issues.

@Tyriar Tyriar merged commit 5cbb1b0 into master Mar 14, 2017
@Tyriar Tyriar deleted the tyriar/19078 branch March 14, 2017 18:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal doesn't honor quoted command lines.

2 participants