Fix Markdown TOC Provider for Invalid References#22553
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Mar 13, 2017
Merged
Fix Markdown TOC Provider for Invalid References#22553mjbvz merged 1 commit intomicrosoft:masterfrom
mjbvz merged 1 commit intomicrosoft:masterfrom
Conversation
Fixes microsoft#22494 **Bug** References without a definition can cause the markdown table of contents provider to break **Fix** Pass in an empty environment to markdown-it `parse` to prevent the null dereference on invalid links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22494
Bug
References without a definition can cause the markdown table of contents provider to break
Fix
Pass in an empty environment to markdown-it
parseto prevent the null dereference on invalid links. Also picks up new markdown it version and fixes a potential case wherecurrentDocumentis undefined