Fix to header misplacement in minimap#217581
Merged
alexdima merged 3 commits intomicrosoft:mainfrom Feb 18, 2025
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
apogee-aim
approved these changes
Oct 11, 2024
RagibHasin
approved these changes
Dec 19, 2024
3noix
reviewed
Feb 8, 2025
3noix
left a comment
3noix
left a comment
There was a problem hiding this comment.
I am totally okay with your changes. I would have already approved them if I had the right to do so. I will be glad once this bug is finally resolved.
|
I sent a brief email to Alex Dima politely requesting a review. @bchu1 could you please confirm this PR is still up-to-date and working today? |
lszomoru
approved these changes
Feb 18, 2025
lszomoru
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #209595
Fixes bug where header would appear in wrong location in minimap when using Fill or Fit (when the file length causes Fit to start compressing the minimap).
It was previously always displaying the header in the location where it would be displayed if Proportional were selected.
Before:
After:
