Add typescript and javascript format.insertSpaceBeforeFunctionParenthesis#21712
Add typescript and javascript format.insertSpaceBeforeFunctionParenthesis#21712mjbvz merged 6 commits intomicrosoft:masterfrom ChiriVulpes:master
Conversation
|
@Aarilight, It will cover your contributions to all Microsoft-managed open source projects. |
|
@Aarilight, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
mjbvz
left a comment
mjbvz
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
Looks good overall, let's just make sure to note which version of TypeScript is required to use this setting
| "format.insertSpaceBeforeAndAfterBinaryOperators": "Defines space handling after a binary operator.", | ||
| "format.insertSpaceAfterKeywordsInControlFlowStatements": "Defines space handling after keywords in a control flow statement.", | ||
| "format.insertSpaceAfterFunctionKeywordForAnonymousFunctions": "Defines space handling after function keyword for anonymous functions.", | ||
| "format.insertSpaceBeforeFunctionParenthesis": "Defines space handling before function argument parentheses.", |
There was a problem hiding this comment.
Please add a Requires TypeScript >= 2.1.5. blurb at the end
|
Thanks! This should be in the next 1.11 insiders build |
|
Using 1.13.1 and having the opposite issue: by default VS Code adds the space and I can't find any way to remove it as otherwise it will lead to too many changes in source code. Have tried to set |
|
@mikhailmelnik Please open an issue (but also check that an extension is not causing this first) |
5 participants
Original Issue
This issue was closed and hasn't been reopened since the feature
has been implemented in TypeScript.
Figured I would try my hand at completing it. I'm too busy at the moment to get a local build working, so I figured I'd just do the changes it looks like are necessary and then make a PR. If it's broken it can be rejected, and in that case I'll apologise for wasting your time. >.>
If you have time and this doesn't provide everything necessary, let me know. I'll try make a local build and update the request with a working version if that's the case.