Merged
Conversation
Contributor
Author
|
closes #209943 |
Heldenkrieger01
approved these changes
Jun 24, 2024
|
Does this bug still need any help? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes bug #209943 where breadcrumb icons could not be hidden. The fix adds logic to respect the showSymbolIcons configuration option when rendering breadcrumb items.
Key Changes:
- Added a check for the
showSymbolIconsoption in theOutlineItemconstructor to conditionally clear icon classes
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Co-authored-by: Copilot <[email protected]>
benvillalobos
approved these changes
Oct 23, 2025
Member
benvillalobos
left a comment
benvillalobos
left a comment
There was a problem hiding this comment.
Verified this myself. Thanks for your contribution (and your patience)!
Tyriar
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for the bug bug "Cannot hide breadcrumb icons" #209943
Recording.2024-06-20.084929.mp4