Skip to content

Make overview ruler border less obtrusive#21459

Merged
alexdima merged 4 commits intomicrosoft:masterfrom
nonphoto:nonphoto/ruler-border
Mar 8, 2017
Merged

Make overview ruler border less obtrusive#21459
alexdima merged 4 commits intomicrosoft:masterfrom
nonphoto:nonphoto/ruler-border

Conversation

@nonphoto
Copy link

Fixes #5099 by making the overview ruler's border less obtrusive on dark color themes, and by adding an option to hide it entirely.

@mention-bot
Copy link

@nonphoto, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @bpasero to be potential reviewers.

@msftclas
Copy link

@nonphoto,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@nonphoto nonphoto changed the title Make overview ruler border visually consistent Make overview ruler border less obtrusive Feb 26, 2017
@alexdima alexdima added this to the March 2017 milestone Feb 27, 2017
@msftgits
Copy link

msftgits commented Mar 3, 2017

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

@msftgits msftgits closed this Mar 3, 2017
@msftgits msftgits reopened this Mar 3, 2017
@msftclas
Copy link

msftclas commented Mar 3, 2017

@nonphoto,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@alexdima alexdima merged commit 1d3a704 into microsoft:master Mar 8, 2017
@alexdima
Copy link
Member

alexdima commented Mar 8, 2017

Thank you for the contribution. Looks good to me, I will follow up with a rename of the setting to make it more consistent with the other settings.

@nonphoto nonphoto deleted the nonphoto/ruler-border branch March 10, 2017 18:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ruler's border is not consistent

5 participants