Expose undo/redo and canUndo/canRedo methods on model API #213954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devlinjunker
force-pushed
the
expose-undo-redo
branch
from
fce484f to
d26fb45
Compare
Contributor
Author
|
@microsoft-github-policy-service agree company="Forward Networks" |
1 similar comment
Contributor
Author
|
@microsoft-github-policy-service agree company="Forward Networks" |
Contributor
Author
|
@alexdima any plans on merging this? |
alexdima
approved these changes
Jul 15, 2025
DonJayamanne
approved these changes
Jul 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice if these methods were exposed in the Monaco editor for use by web applications. I don't know why there would be a requirement for them to be internal only.
To test these changes, rebuild monaco from the vs source and ensure that the methods are included in the external api spec: https://github.com/microsoft/monaco-editor/blob/gh-pages/node_modules/monaco-editor/monaco.d.ts
I could not find a specific issue that maps to this change, but I have seen reference to it on stackoverflow and it would be great for my use.