Add debug window context menu contribution points #212501
Conversation
Signed-off-by: thegecko <[email protected]>
| const context = delegate.getActionsContext ? delegate.getActionsContext(event) : undefined; | ||
| // Determine whether the action source is contributed via a proxy (e.g. from an external extension) | ||
| // Context will need to be serializable (e.g. no recursive structures) | ||
| const contributedAction = (actionToRun instanceof MenuItemAction) && actionToRun?.item?.source; |
There was a problem hiding this comment.
Due to the existing context menus already utilising referenced objects in their commands which cannot be serialised (e.g. due to circular references or bigint types), a mechanism is required to determine if the context menu item has been contributed by an external extension.
The method chosen here relies on a source existing for external contributions. I'm not a bug fan of this, is there a better way?
There was a problem hiding this comment.
We shouldn't try to use two different contexts for one toolbar. That is one thing that has always been an issue with exposing menus to extensions, and I'm not sure whether there's a better way to handle it, I will try to discuss that this week.
|
|
||
| return { | ||
| sessionId: this.debugService.getViewModel().focusedSession?.getId(), | ||
| expressionId: expression.getId(), |
There was a problem hiding this comment.
I don't think this ID is meaningful or exposed to extensions elsewhere, or is it?
There was a problem hiding this comment.
You could be right, but it may be useful as a unique ID?
|
I assume this went stale @roblourens |
|
@roblourens Now we have #212500 merged, I'm keen to revisit contribution points for the debug context menus in this PR. I'm happy to rebase it, but want to confirm this is the correct approach first. TY. |
2 participants
As discussed in #200880 we are keen to ensure there are contribution points in all debug window context menus
This proposal implements contribution points for the watch, breakpoints and disassembly views.
To use this proposal, the
package.jsonwould look similar to:{ ... "enabledApiProposals": [ "debugContext" ], "contributes": { "commands": [ { "command": "proposed.dummyMenu", "title": "Dummy Menu" } ], "menus": { "debug/disassembly/context": [ { "command": "proposed.dummyMenu" } ], "debug/watch/context": [ { "command": "proposed.dummyMenu" } ], "debug/breakpoints/context": [ { "command": "proposed.dummyMenu" } ] } }, ...An example can be found here: https://github.com/thegecko/vscode-proposed-debug
Fixes: #200880, #150161
Relates with: #212500