Skip to content

Conversation

@omar-cs
Copy link
Contributor

@omar-cs omar-cs commented Apr 26, 2024

Adding Cursor Height: #168531

Description: The main changes were made when rendering the cursor. Upon each change in position of the cursor, it performs checks to determine its height. The cursor's height is dependent upon the font size and the line height. The cursor height cannot exceed the max of either line height or font size. Line height could be less than both, but never exceed.

Implementation Examples

Screenshot 2024-04-26 170845
Screenshot 2024-04-26 170851

… cursor height each time cursor is rendered. Cursor height is dependent on font line height and font size.
@omar-cs
Copy link
Contributor Author

omar-cs commented Apr 26, 2024

@microsoft-github-policy-service agree

alexdima
alexdima previously approved these changes Jul 15, 2025
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and apologies for the slow turn-around time!

@vs-code-engineering vs-code-engineering bot added this to the July 2025 milestone Jul 15, 2025
@alexdima alexdima enabled auto-merge (squash) July 15, 2025 18:53
@alexdima alexdima merged commit 648281e into microsoft:main Jul 15, 2025
17 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants