#134898 - trimming whitespace when deleting new line character #210870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
|
@adityavc I'm very sorry for missing this PR, will look into this. |
alexdima
previously approved these changes
Jul 15, 2025
DonJayamanne
previously approved these changes
Jul 15, 2025
DonJayamanne
approved these changes
Jul 15, 2025
alexdima
approved these changes
Jul 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trim Whitespace on Newline Character Deletion: #134898
Description: The main changes were made to the getDeleteRange function -- when deleting a new line character, the range will be the last non whitespace character in the first line to the first non whitespace character in the second line.
However, there are some exceptions, if the line with the new line character does not have text (only contains spaces/tabs) then left white space is not trimmed. Additionally if the line with new line character is empty then the right white space is not trimmed. This is to preserve any indented code while deleting.
Example:
deleting the new line character will result in
Testing: a unit test was created in cursor.test to verify functionality.
I found this issue when going through the backlog -- unsure if it's still desired functionality.
Fixes #134898