Hi @timorthi thank you for the PR. After looking at the code, I believe the cleanest way to solve this issue would be to refactor the code so that we have a method readConfiguration which would read the configuration, and have another method readConfigurationChange which would take in the configuration change event as a parameter. Then you could write:

readConfigurationChange(e : ConfigurationChange) {
  this.readConfiguration();
  ...
  if (e.hasChanged(EditorOption.lineNumbers)) {
      this._renderStickyScroll(0);
  }
}

In this manner the readConfigurationChange method would reuse the readConfiguration method and would add additional logic on top in the form of rerendering the widget under specific conditions.

The following check:

if (
    e.hasChanged(EditorOption.stickyScroll)
    || e.hasChanged(EditorOption.minimap)
    || e.hasChanged(EditorOption.lineHeight)
    || e.hasChanged(EditorOption.showFoldingControls)
    || e.hasChanged(EditorOption.lineNumbers)
) 

Should also be placed in the readConfigurationChange method in that case.

@aiday-mar Updated!

@microsoft-github-policy-service agree

Great thanks!