Clear Activity Bar icon badge correctly (fix #210640)#210645
Merged
alexr00 merged 1 commit intomicrosoft:mainfrom Apr 18, 2024
Merged
Clear Activity Bar icon badge correctly (fix #210640)#210645alexr00 merged 1 commit intomicrosoft:mainfrom
alexr00 merged 1 commit intomicrosoft:mainfrom
Conversation
chrmarti
approved these changes
Apr 18, 2024
Contributor
Author
|
@alexr00 thanks for accepting this. For some reason the auto-merge hasn't triggered, so please do it manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #210640
When an extension sets a TreeView.badge and subsequently clears it by setting it
undefined, remove the badge from the Activity Bar icon.