fix: terminal suggestions should hide modal when no completions exist#210289
Merged
Tyriar merged 1 commit intomicrosoft:mainfrom Apr 15, 2024
cpendery:feat/hide-modal
Merged
fix: terminal suggestions should hide modal when no completions exist#210289Tyriar merged 1 commit intomicrosoft:mainfrom cpendery:feat/hide-modal
Tyriar merged 1 commit intomicrosoft:mainfrom
cpendery:feat/hide-modal
Conversation
Signed-off-by: Chapman Pendery <[email protected]>
Tyriar
approved these changes
Apr 15, 2024
meganrogge
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue similar to #208822 where the
anyaccess of the private variables don't work once bundled for insiders. It causes the empty modal to hang instead of hiding.Currently in Insiders
beforeEmpty.mp4
Part of #154662