Add command line confidence to shellIntegration API#209946
Merged
Conversation
meganrogge
reviewed
Apr 9, 2024
meganrogge
reviewed
Apr 9, 2024
meganrogge
reviewed
Apr 9, 2024
| @@ -112,8 +112,8 @@ __vsc_update_cwd() { | |||
| } | |||
Collaborator
There was a problem hiding this comment.
why were these moved to below?
Member
Author
There was a problem hiding this comment.
To get the command line before command execute fires, this should greatly improve the results and likely other features from shell integration too
meganrogge
reviewed
Apr 9, 2024
meganrogge
previously approved these changes
Apr 9, 2024
Co-authored-by: Megan Rogge <[email protected]>
meganrogge
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part #145234