Fix incorrect typings in OpenJsDocLinkCommand_Args#209872
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Apr 8, 2024
Merged
Fix incorrect typings in OpenJsDocLinkCommand_Args#209872mjbvz merged 1 commit intomicrosoft:mainfrom
OpenJsDocLinkCommand_Args#209872mjbvz merged 1 commit intomicrosoft:mainfrom
Conversation
mjbvz
approved these changes
Apr 8, 2024
Tyriar
approved these changes
Apr 8, 2024
Contributor
Author
|
Thank you very much for so prompt review and merging -- really great contributing experience! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue in
openJsDocLinkcommand due to incorrect typings inOpenJsDocLinkCommand_Args.The
openJsDocLinkcommand currently declares the type of itsargsparameter asHowever, the type of the actual argument given to the command is
As a consequence, while the command does convert
args.filetovscode.Uriviavscode.Uri.from(args.file), it misses convertingargs.positiontovscode.Position. This works by accident in VS Code, but causes an issue in Eclipse Theia (eclipse-theia/theia#13568).This PR fixes the typings in
OpenJsDocLinkCommand_Argsand adds the necessary conversion forargs.position.