Fix #201247 (Integrated Terminal does not set the environment variables from default profile)#209711
Merged
Tyriar merged 2 commits intomicrosoft:mainfrom Apr 8, 2024
Merged
Conversation
Contributor
Author
@microsoft-github-policy-service agree |
r-sargento
force-pushed
the
defaultProfile-env
branch
from
0c5e18f to
1279e45
Compare
r-sargento
changed the title
meganrogge
approved these changes
Apr 8, 2024
Collaborator
meganrogge
left a comment
meganrogge
left a comment
There was a problem hiding this comment.
Thank you, it works well
Tyriar
approved these changes
Apr 8, 2024
Tyriar
added a commit
that referenced
this pull request
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #201247
The bug was caused because, SLC was only updating icon and color. Just added 2 lines to also get env.
Also made a new unit test, which uses a MockTerminalProfileResolver to always return a default profile with a specific env. Then I create the TerminalInstance, after that I wait for the _xtermReadyPromisse to resolve and after that I check if the env is in the SLC. Also had to add some _register in TerminalInstance to fix some leaks