fix: minimap section header display uncompletely on first load:#209603#209605
Merged
alexdima merged 4 commits intomicrosoft:mainfrom Apr 10, 2024
Merged
Conversation
Contributor
Author
|
Hi, @alexdima Could you look at this please. |
Tyriar
approved these changes
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix This addresses issue: #209603
I am very interested in the
Minimap section headersfeature, hope to fix this issue with this PR.After a day of debugging this issue, I finally found out where the bug is. When the editor loads the file for the first time, if the file is too long, the tokens obtained through the
getLineTokensinterface for the code at the bottom of the first screen window are not accurate, and they will be wrongly filtered out when generating the section header.Therefore, we need to get more accurate tokens first, and the
token index offsetcalculated from them is accurate, so that the corresponding section header will not be wrongly filtered out.In addition, this modification will not affect other modules features.
After the fix, minimap section header display completely on first load, like photo below:
Thanks for reviewing.