Skip to content

Hot Exit: Opens the same file twice in two separate windows#20938

Merged
bpasero merged 2 commits intomasterfrom
ben/16820
Feb 21, 2017
Merged

Hot Exit: Opens the same file twice in two separate windows#20938
bpasero merged 2 commits intomasterfrom
ben/16820

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Feb 20, 2017

For: #16820

We have logic that decides on startup if files should open inside a separate window or new window. When we know that we open a window with a folder we always open files in that window. However we are not doing so when we know that we open a window with a folder that contains hot-exit files or an untitled window with hot-exit files.

This fix will prefer a folder with dirty files (or untitled window with dirty files to restore) to open the files in in order to fix #16820

@mention-bot
Copy link

@bpasero, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma and @joaomoreno to be potential reviewers.

@bpasero bpasero merged commit 25c5563 into master Feb 21, 2017
@bpasero bpasero deleted the ben/16820 branch February 21, 2017 06:44
@labregowski
Copy link

Hi.
I have the same issue (VSC opening twice ). But still I don't know how to solve it.
I understood the solution goes as ... windows.ts#open() ... from ... #16820
BUt I don't knw where to type that command (or to add it to a bash file).
Any help?

@Tyriar
Copy link
Member

Tyriar commented Oct 31, 2018

@labregowski please create a new issue if you have a problem with the latest version.

@microsoft microsoft locked and limited conversation to collaborators Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hot Exit: Opens the same file twice in two separate windows

5 participants