Terminal encoding problem related to issue #14586#20932
Terminal encoding problem related to issue #14586#20932Tyriar merged 4 commits intomicrosoft:masterfrom
Conversation
|
@matheusrocha89, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Tyriar and @dbaeumer to be potential reviewers. |
|
Hi @matheusrocha89, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
matheusrocha89
changed the title
… called if no locale passed to create terminal
| env['PTYCOLS'] = cols.toString(); | ||
| env['PTYROWS'] = rows.toString(); | ||
| } | ||
| if (!env['LANG']) { |
There was a problem hiding this comment.
I think it's a good idea to have a fallback, but this would probably be better in _getLangEnvVariable instead, replacing the n === 0 case 👍
There was a problem hiding this comment.
I think too... I will do that.
|
@matheusrocha89 could you also please sign the CLA mentioned in #20932 (comment)? |
|
@Tyriar I already signed, I also received the confirmation email. |
|
Hi @matheusrocha89, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
Great! Thanks for looking into this 😃 |
|
You're welcome. Thank you to help me with this @Tyriar |
4 participants
This PR try to fix the special chars encoding problem when the
$LANGvariable is not set on user's Mac. More information about this problem on #14586