Add windowOptions to xtermTerminal to allow ESC [18t to work#209310
Merged
Tyriar merged 1 commit intomicrosoft:mainfrom Apr 2, 2024
Merged
Add windowOptions to xtermTerminal to allow ESC [18t to work#209310Tyriar merged 1 commit intomicrosoft:mainfrom
windowOptions to xtermTerminal to allow ESC [18t to work#209310Tyriar merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@Tyriar would you be able to take a look at this? I think it's pretty straightforward. |
Tyriar
approved these changes
Apr 2, 2024
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Looks good, thanks!
This option is disabled by default for security reasons, but I reviewed what gets sent from xterm.js and all looks fine as it doesn't contain arbitrary strings, only numbers and the possibility of undefined.
meganrogge
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #209309 by allowing the three supported
windowOptionsquery targets in xterm.js.Test:
echo -e "\x1b[18t"