Fix missing class in inlinesuggest toolbar in Monaco-Editor causing CSS variables to be ineffective#207582
Merged
hediet merged 2 commits intomicrosoft:mainfrom Mar 28, 2024
Merged
Fix missing class in inlinesuggest toolbar in Monaco-Editor causing CSS variables to be ineffective#207582hediet merged 2 commits intomicrosoft:mainfrom
hediet merged 2 commits intomicrosoft:mainfrom
Conversation
Collaborator
|
cc @hediet as assignee of monaco issue linked here |
Member
|
Thank you! |
hediet
approved these changes
Mar 28, 2024
bpasero
approved these changes
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug is about monaco-editor issue.
I want to fix this bug in monaco-edtior project and I read its contribution guide and I find it builds from vscode,so I make a pr here.
current monaco editor（error style）：
my fix of monaco editor（right style）
the reason of my fix：
the action bar lose css color variables which are from other css class，so I add a
monaco-componentclass to the context-view elementwhy vscode is ok
vscode seems to use electron-menu and it dont need css style to make it looks right