Skip to content

Conversation

@hsfzxjy
Copy link
Contributor

@hsfzxjy hsfzxjy commented Mar 2, 2024

Fix #204009

Copy link
Contributor

@balaji-sivasakthi balaji-sivasakthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roblourens
Copy link
Member

Thoughts @connor4312? What bugs me is that I always still have to move my hands to the keyboard after this anyway, so I wonder how much it speeds things up. And there's no way for anybody to discover this.

@connor4312
Copy link
Member

I always set logpoints via the context menu in the gutter, so there would be a marginal benefit for me, at least until I set up a keybinding for that command 😛

I'm not opposed to this, but there's no reason logpoint is special: the type of breakpoint should probably be configurable via a setting if we go this route.

@hsfzxjy
Copy link
Contributor Author

hsfzxjy commented Mar 6, 2024

the type of breakpoint should probably be configurable via a setting if we go this route

Agreed. I will proceed to add configuration for this.

@hsfzxjy hsfzxjy force-pushed the middle-click-add-log-bp-204009 branch from 2478763 to 7d0556c Compare March 6, 2024 13:43
@connor4312
Copy link
Member

This seems decent to me, what do you think @roblourens?

@roblourens
Copy link
Member

I don't have a mouse at the moment, so I can't properly test it. But I like the setting in principal, this is fine with me.

@connor4312 connor4312 enabled auto-merge March 14, 2024 03:14
@vscodenpa vscodenpa added this to the March 2024 milestone Mar 14, 2024
@connor4312 connor4312 closed this Mar 14, 2024
auto-merge was automatically disabled March 14, 2024 15:53

Pull request was closed

@connor4312 connor4312 reopened this Mar 14, 2024
@connor4312 connor4312 enabled auto-merge (squash) March 14, 2024 15:53
@connor4312 connor4312 merged commit 728ccf4 into microsoft:main Mar 14, 2024
@hsfzxjy hsfzxjy deleted the middle-click-add-log-bp-204009 branch March 14, 2024 16:24
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use middle click to set a logpoint

6 participants