-
Notifications
You must be signed in to change notification settings - Fork 37.4k
Add log point on middle clicking gutter #206684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log point on middle clicking gutter #206684
Conversation
balaji-sivasakthi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Thoughts @connor4312? What bugs me is that I always still have to move my hands to the keyboard after this anyway, so I wonder how much it speeds things up. And there's no way for anybody to discover this. |
|
I always set logpoints via the context menu in the gutter, so there would be a marginal benefit for me, at least until I set up a keybinding for that command 😛 I'm not opposed to this, but there's no reason logpoint is special: the type of breakpoint should probably be configurable via a setting if we go this route. |
Agreed. I will proceed to add configuration for this. |
2478763 to
7d0556c
Compare
|
This seems decent to me, what do you think @roblourens? |
|
I don't have a mouse at the moment, so I can't properly test it. But I like the setting in principal, this is fine with me. |
Fix #204009