Skip to content

markdown-it-named-header custom slugify for non-latin characters#20628

Merged
mjbvz merged 2 commits intomicrosoft:masterfrom
satokaz:satokaz/mdnh-slugify
Feb 15, 2017
Merged

markdown-it-named-header custom slugify for non-latin characters#20628
mjbvz merged 2 commits intomicrosoft:masterfrom
satokaz:satokaz/mdnh-slugify

Conversation

@satokaz
Copy link
Contributor

@satokaz satokaz commented Feb 15, 2017

Issues: non-latin characters (such as japanese) and Markdown preview anchor #20626

PROBLEM:

I want to realize an in-page link by using an anchor in Markdown Preview, but it does not work with non-latin characters.
If the header is written in non-latin characters (such as Japanese), it is judged to be an invalid character, so the value of the id attribute is empty.

@msftclas
Copy link

Hi @satokaz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@mjbvz mjbvz self-assigned this Feb 15, 2017
@mjbvz mjbvz merged commit ac5beb6 into microsoft:master Feb 15, 2017
@mjbvz mjbvz added this to the February 2017 milestone Feb 15, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 15, 2017

Thank you for the contribution! This looks like a good change and it should be in the next insiders build

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants