Fix accidental dedent for in and when dedent in Ruby comments
#206132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
vs/fix_in_dedent_in_comments
branch
from
f6bf0c4 to
228a35f
Compare
Member
|
@vinistock thanks for the quick fix! Does it only affect comments? We are in endgame mode so I'm trying to understand if it's worth a candidate or if we should pull back the previous change and merge together with this one. |
rebornix
approved these changes
Feb 23, 2024
connor4312
approved these changes
Feb 23, 2024
Contributor
Author
|
@rebornix because of the unbalanced parenthesis, it ignores the I don't know what the endgame policies are, but in my opinion it's definitely worth either pulling back the previous change or including this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing the changes from #205397 in Insiders and I noticed that the code was incorrectly being dedented when typing
inorwhenin comments.We got the parenthesis balance incorrect in the regex. The regex has three outer groups for an or condition and we closed the group incorrectly, which made the last part of the regex skip the
\s*part (which verifies that only blank spaces are in the front of the string).This PR fixes the bug by properly balancing the parenthesis. The tests was also missing the
^anchor, which I added to match the language configuration.cc @rebornix