feat. add a menu item 'expand-select' to expand subtree in search view#206033
feat. add a menu item 'expand-select' to expand subtree in search view#206033andreamah merged 2 commits intomicrosoft:mainfrom
Conversation
|
Middle click (scroll click/button 3) is often used for toggling between expanding and collapsing nested items |
|
@microsoft-github-policy-service agree |
andreamah
left a comment
There was a problem hiding this comment.
Just a few small changes 👍
I think the search view already supports this, where middle click expands one level. Is this what you meant, or is there still missing functionality? |
I meant for recursive expansion. I will update my code to make work, thx for reviewing. |
yeah I meant for recursively nested items |
As in the middle click should recursively open nested items? Does this only happen in the editor with nested ranges, or does it happen in other tree views? |
|
yes, I would like middle click to recursively open nested items. I'm pretty sure there was something else that did support it |
|
I tried and also checked the code, "middle mouse for recursively expansion" only works for foldings in the editor. vscode/src/vs/editor/contrib/folding/browser/folding.ts Lines 492 to 499 in 1f94e5c |
580d02a to
fe61dc6
Compare
|
Do we use the language "Expand Selected" anywhere else? Otherwise, I would prefer just "Expand" since it's implied that it's acting on selected elements. |
no, the term "Expand Selected" does not in anywhere else. should I modify it as "Expand the Tree" or something similar, since this is quite a different behavior to what "Expand" implies. |
fe61dc6 to
10dc3e8
Compare
|
I think they both are good, and how about "Expand from This"? or maybe should be more succinct. I don't have any preferences on this |
|
I think "Expand Recursively" would be the best from my perspective, since it seems less wordy in my opinion. |



Implementation of #206032