Skip to content

Open vscode://file/path/to/project/ URLs properly on Windows - fixes #20290#20469

Merged
joaomoreno merged 6 commits intomicrosoft:masterfrom
jordanmkasla2009:master
Apr 12, 2017
Merged

Open vscode://file/path/to/project/ URLs properly on Windows - fixes #20290#20469
joaomoreno merged 6 commits intomicrosoft:masterfrom
jordanmkasla2009:master

Conversation

@jordanmkasla2009
Copy link
Contributor

Opening vscode://file/c/path/to/project/or/file.txt will no longer fail on Windows.

Tested using multiple drive letters and file/folder paths.

@mention-bot
Copy link

@jordanmkasla2009, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joaomoreno and @bpasero to be potential reviewers.

@msftclas
Copy link

Hi @jordanmkasla2009, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@jordanmkasla2009 jordanmkasla2009 changed the title Open vscode://file/path/to/project/ URLs properly on Windows (fixes #20290) Open vscode://file/path/to/project/ URLs properly on Windows - fixes #20290 Feb 11, 2017
@msftclas
Copy link

Hi @jordanmkasla2009, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@joaomoreno
Copy link
Member

Related to #20290

@joaomoreno joaomoreno added this to the March 2017 milestone Feb 13, 2017
@joaomoreno joaomoreno modified the milestones: March 2017, April 2017 Mar 30, 2017
@joaomoreno joaomoreno merged commit 300f282 into microsoft:master Apr 12, 2017
@joaomoreno
Copy link
Member

Thanks @jordanmkasla2009 !

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants