Pass the check if any one of the library (of the arch) satisfies the requirement. #204221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
|
Pinging @deepak1556 |
deepak1556
reviewed
Feb 5, 2024
Collaborator
deepak1556
left a comment
deepak1556
left a comment
There was a problem hiding this comment.
Makes sense, thanks!
|
The loop over I've no system with more than one |
Collaborator
|
Thanks for confirming! |
Contributor
Author
|
@deepak1556 The suggestions all look good to me. Do I need to commit the suggestions or resolve the comments? |
Collaborator
|
Feel free to do either, commit suggestions from github or make the changes locally and commit them (which will also resolve the comments) |
Contributor
Author
|
I like your exit checks. Easier to read! Thanks for all the efforts on VSCode! |
DonJayamanne
previously approved these changes
Feb 6, 2024
Pass the check if one of the library (of the arch) satisfies the requirement.
Co-authored-by: Robo <[email protected]>
Co-authored-by: Robo <[email protected]>
Co-authored-by: Robo <[email protected]>
Co-authored-by: Robo <[email protected]>
Co-authored-by: Robo <[email protected]>
Co-authored-by: Robo <[email protected]>
deepak1556
dismissed stale reviews from DonJayamanne and themself
via
e09b14f
rzhao271
approved these changes
Feb 7, 2024
connor4312
approved these changes
Feb 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the check if any one of the library (of the arch) satisfies the requirement.
Fixes microsoft/vscode-remote-release#9475