Skip to content

Conversation

@gjsjohnmurray
Copy link
Contributor

This fixes #202870.

When filtering the checkout quickpick the command entries are retained but demoted to the end of the list.

Copy link
Contributor Author

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @lszomoru

@lszomoru
Copy link
Member

lszomoru commented Feb 5, 2024

@gjsjohnmurray, thank you very much for the contribution.

Before getting this into the vscode.git extension I would like to give @TylerLeonhardt an opportunity to chime in to see whether it would make sense to have this added to VS Code core instead of the extension. Essentially we would like to show quick pick items marked as alwaysShow at the end of the list when searching.

@lszomoru lszomoru added this to the February 2024 milestone Feb 5, 2024
@lszomoru
Copy link
Member

lszomoru commented Feb 7, 2024

@gjsjohnmurray, thanks again for the contribution. I have pushed a commit to the PR so that we do not have to filter the quick pick items when the value of the input field changes. I have tested the changes but I was wondering if you could take a look to make sure that I did not miss something. Thanks!

@gjsjohnmurray
Copy link
Contributor Author

Seems good to me. Thanks for the improvement.

@lszomoru lszomoru enabled auto-merge (squash) February 7, 2024 19:45
@lszomoru lszomoru merged commit 6c7362f into microsoft:main Feb 7, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
@gjsjohnmurray gjsjohnmurray deleted the fix-202870 branch August 16, 2024 05:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Branch selection should always offer 'create' and 'create from'

4 participants