Fix inoperative try/catch #203904
Merged
Fix inoperative try/catch #203904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulugbekna
approved these changes
Feb 7, 2024
Contributor
|
nice catch, thank you! ❤️ |
roblourens
approved these changes
Feb 7, 2024
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
If you're gonna await it, I would rather see the .then removed, I find it confusing to mix and match
Contributor
|
I agree with the comment above, but let's address it in another PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a try/catch preventing errors
if invoked from a nested browsing contextbut at least in lastest chrome, the method returns a rejected promise in that case and the try/catch does nothing leading to an uncaught error