Added support for home/end key in IntelliSense#20156
Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom Apr 11, 2017
Merged
Added support for home/end key in IntelliSense#20156joaomoreno merged 2 commits intomicrosoft:masterfrom
joaomoreno merged 2 commits intomicrosoft:masterfrom
Conversation
…rt for details view/state is yet to come.
|
@mlewand, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joaomoreno and @alexandrudima to be potential reviewers. |
|
Hi @mlewand, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
Contributor
Author
|
Hi @joaomoreno just checking if there's any chance to have it reviewed any time soon? It was fairly simple PR, requiring to add few methods. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a support for
home/endkeys in IntelliSense. I had basically the very same expectaction / feeling as given in #18656.Everything is pretty straight-forward except:
suggestWidget,listWidget, am I missing something?