Hi @tgjones, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

Hi @tgjones, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@aeschli Can you please take a look at this change. It looks good to me but you know much more about the general language support

@tgjones Thanks a lot Tim for the great work. Separating HLSL and ShaderLab sounds like a good idea.
Why I'm hesitating and I wanted to talk to @egamma about it, is that this would be the first grammar that we would 'own', where the original version lives in the VSCode repository. For all other languages we import the grammars from other repositories. Having the grammar in a separate repository has the advantage that the grammar can be maintained independently by the original authors or other committers. There's no need for the VSCode team to review and merge every change. Another benefit is that the grammar can be made available to other editors as well.
https://github.com/Microsoft/TypeScript-TmLanguage is an example for such a repository.
We forward issues to that repository and, from time to time, or on request, import the latest grammar to VSCode.
I'd suggest we follow the same model here.
@tgjones What do you think?
That would mean you create your own github repository that just contains the grammar.
In order for us to use it all we need is a friendly open source licence such as MIT.

@aeschli that sounds very sensible to me. In fact I've already created such a repository, because GitHub's Linguist (used for syntax highlighting on github.com) requires grammars to be in a submodule, and I've got an active PR over there for adding HLSL syntax highlighting. I'll modify this PR once I get back to my computer.

Cool. What's missing to the PR is just a grammar update script plus an updated OSSREADME.
If you point me to your repository I can make that change.

Ah, I see https://github.com/tgjones/shaders-tmLanguage. I'll make the update.

Great, thanks for merging!