fix: memory leak in simple find widget #198978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR. I already prepared fix for the |
SimonSiefke
changed the title
Contributor
Author
|
Thanks! I made a separate issue for the simpleFindWidget: #199043 and updated this PR. It seems {
"eventListenersWithStackTrace": [
{
"type": "-monaco-gesturetap",
"description": "(e)=>this.emitter.fire(e)",
"objectId": "-6782061013704719865.4.16307",
"sourceMaps": [""],
"stack": [
"listener (vscode/out/vs/base/browser/event.js:17:23)",
"Object.onWillAddFirstListener (vscode/out/vs/base/browser/event.js:20:53)",
"_event (vscode/out/vs/base/common/event.js:650:60)",
"new Sash (vscode/out/vs/base/browser/ui/sash/sash.js:241:28)",
"new SimpleFindWidget (vscode/out/vs/workbench/contrib/codeEditor/browser/find/simpleFindWidget.js:176:36)",
"new WebviewFindWidget (vscode/out/vs/workbench/contrib/webview/browser/webviewFindWidget.js:33:13)",
"InstantiationService._createInstance (vscode/out/vs/platform/instantiation/common/instantiationService.js:103:28)",
"InstantiationService.createInstance (vscode/out/vs/platform/instantiation/common/instantiationService.js:78:31)",
"new WebviewElement (vscode/out/vs/workbench/contrib/webview/browser/webviewElement.js:298:79)",
"new ElectronWebviewElement (vscode/out/vs/workbench/contrib/webview/electron-sandbox/webviewElement.js:47:13)",
"InstantiationService._createInstance (vscode/out/vs/platform/instantiation/common/instantiationService.js:103:28)",
"InstantiationService.createInstance (vscode/out/vs/platform/instantiation/common/instantiationService.js:78:31)",
"ElectronWebviewService.createWebviewElement (vscode/out/vs/workbench/contrib/webview/electron-sandbox/webviewService.js:16:56)",
"OverlayWebview._show (vscode/out/vs/workbench/contrib/webview/browser/overlayWebview.js:164:54)",
"OverlayWebview.claim (vscode/out/vs/workbench/contrib/webview/browser/overlayWebview.js:110:18)",
"ExtensionEditor.openMarkdown (vscode/out/vs/workbench/contrib/extensions/browser/extensionEditor.js:636:25)",
"async ExtensionEditor.openDetails (vscode/out/vs/workbench/contrib/extensions/browser/extensionEditor.js:768:33)"
],
"count": 42
}
],
"isLeak": true
}
|
Contributor
|
Sash did not dispose. 😅 |
Merged
rebornix
approved these changes
Nov 27, 2023
Member
rebornix
left a comment
rebornix
left a comment
There was a problem hiding this comment.
Thank you for the investigation and fix!
lramos15
approved these changes
Nov 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #199043
Output with
--measure event-listeners{ "eventListeners": [], "isLeak": false }