Stop the cursor from jumping when changing prefix in QuickAccess #198821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Marking as ready for review as we have had this change on prod in our internal fork for 2 weeks with no reported issues. |
Contributor
Author
|
@TylerLeonhardt - friendly ping. |
TylerLeonhardt
approved these changes
Feb 4, 2024
Member
TylerLeonhardt
left a comment
TylerLeonhardt
left a comment
There was a problem hiding this comment.
Very clean. I like this! Thanks for fixing!
chrmarti
approved these changes
Feb 5, 2024
Member
|
Hi @a-stewart. Unfortunately,I had to revert this PR as it caused this issue: #204572 sorry If you can come up with a solution that fixes the existing issue and doesn't cause that issue, I would accept a PR |
Contributor
Author
|
Sorry for that - I'll have a look and see if that can be avoided. Hopefully |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #162914
When changing the prefix, we should check the cursor position on the currently visible picker (if one exists), and if so we should set this as the position for the new picker.
This requires a few changes to create a getter method for the selection, which doesn't currently exist.
Current (broken):
This PR:
