Simplify 'solid' || '' in viewPaneContainer.ts#198515
Merged
mjbvz merged 2 commits intoNov 20, 2023
Merged
Conversation
Contributor
|
Not sure if I should assign this to you @mjbvz ? |
mjbvz
approved these changes
Nov 20, 2023
rzhao271
approved these changes
Nov 20, 2023
Splizard
pushed a commit
to Splizard/vscode-mobile
that referenced
this pull request
Nov 21, 2023
Remove odd or in viewPaneContainer.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a slightly odd string in viewPaneContrainer.ts which is set to
'solid' || ''. Since the LHS is constant and truthy, this is identical to just setting the value to'solid'(but slightly less readable).My guess is that this was initially a variable, and then became constant. There is probably no issue as I assume most compilers would compile this out, but ours gives an error of
JSC_SUSPICIOUS_LEFT_OPERAND_OF_LOGICAL_OPERATORso we patch it out.