Skip to content

Sticky scroll for terminal#197558

Merged
Tyriar merged 45 commits intomainfrom
tyriar/172742_sticky_scroll
Nov 8, 2023
Merged

Sticky scroll for terminal#197558
Tyriar merged 45 commits intomainfrom
tyriar/172742_sticky_scroll

Conversation

@Tyriar
Copy link
Copy Markdown
Contributor

@Tyriar Tyriar commented Nov 6, 2023 •
edited
Loading

Fixes #172742

@Tyriar Tyriar added this to the November 2023 milestone Nov 6, 2023
@Tyriar Tyriar self-assigned this Nov 6, 2023
@Tyriar Tyriar changed the title Sticky scroll WIP Sticky scroll for terminal Nov 6, 2023
Tyriar added 26 commits November 6, 2023 07:15
@Tyriar
Merge branch 'main' into tyriar/172742_sticky_scroll
f5c4e3d
@Tyriar
Fix compile errors
4faf905
@Tyriar
Get sticky scroll rendering with an xterm instance
74202a4
@Tyriar
Clean up, track buffer change
bcf5c8f
@Tyriar
Impl click to scroll, reuse from mark nav
38395b2
@Tyriar
React to scroll events
275a1a5
@Tyriar
Fix most sticky scroll bg styles
3cfbb33
@Tyriar
Hide sticky scroll in some cases
cf5656a
@Tyriar
Don't show sticky scroll for null commands
0f40f35
@Tyriar
Improve flow of refresh function
c5b893b
@Tyriar
Separate sticky scroll overlay logic and setup logic
75c624f
@Tyriar
Refactors for maintainability
de600a1
@Tyriar
Improve setting of visibility
e8d840d
@Tyriar
Reduce unnecessary option syncing
80ada7f
@Tyriar
Simplify early returns
fa39026
@Tyriar
Add terminal sticky scroll setting
80e6659
@Tyriar
Set default terminal sticky scroll in vscode temporarily
42a2de2
@Tyriar
Improve lifecycle/registering in term sticky scroll
1baf782
@Tyriar
Don't write content if it didn't change
b69e183
@Tyriar
Remove done todos
e778bc5
@Tyriar
Make sticky scroll terminal editor aware
c204ef0
@Tyriar
Reduce CommandDetectionCapability.getCommandForLine GC pressure
3a21f7e
@Tyriar
Share code in command detection
54d1410
@Tyriar
Tidy up
0bbbea7
@Tyriar
Add simple terminal sticky scroll smoke test
64ac05a
@Tyriar
Fix sticky scroll smoketest on linux
26db70d
@Tyriar Tyriar force-pushed the tyriar/172742_sticky_scroll branch from 7382954 to df036f0 Compare November 8, 2023 16:44
meganrogge
meganrogge previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

meganrogge
meganrogge previously approved these changes Nov 8, 2023
View reviewed changes
meganrogge
meganrogge previously approved these changes Nov 8, 2023
View reviewed changes
@Tyriar Tyriar enabled auto-merge November 8, 2023 19:30
meganrogge
meganrogge previously approved these changes Nov 8, 2023
View reviewed changes
@Tyriar Tyriar merged commit f4aee33 into main Nov 8, 2023
@Tyriar Tyriar deleted the tyriar/172742_sticky_scroll branch November 8, 2023 20:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

November 2023

Development

Successfully merging this pull request may close these issues.

Sticky scroll for terminal commands

2 participants

@Tyriar @meganrogge