Skip to content

Fix explorer selection state when drag ends#19667

Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom
initialshl:fix-treeview-dnd-escape-key
Feb 6, 2017
Merged

Fix explorer selection state when drag ends#19667
joaomoreno merged 2 commits intomicrosoft:masterfrom
initialshl:fix-treeview-dnd-escape-key

Conversation

@initialshl
Copy link
Contributor

@initialshl initialshl commented Feb 1, 2017

Fixes #2367

When a file is dragged onto tree view from desktop and escape key is pressed, the dragend event does not fire.

This fix relies on the property that such an event has a position of (0 , 0).

@mention-bot
Copy link

@initialshl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma and @jrieken to be potential reviewers.

@msftclas
Copy link

msftclas commented Feb 1, 2017

Hi @initialshl, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@initialshl initialshl changed the title Update explorer TreeView selection state when drag ends Fix explorer TreeView selection state when drag ends Feb 1, 2017
@initialshl initialshl changed the title Fix explorer TreeView selection state when drag ends Fix explorer selection state when drag ends Feb 1, 2017
@joaomoreno joaomoreno added this to the February 2017 milestone Feb 1, 2017
@initialshl initialshl closed this Feb 2, 2017
@initialshl initialshl reopened this Feb 2, 2017
@msftclas
Copy link

msftclas commented Feb 2, 2017

Hi @initialshl, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@joaomoreno joaomoreno merged commit cb4a136 into microsoft:master Feb 6, 2017
@joaomoreno
Copy link
Member

Looking great, thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

all of the explorer is selected

4 participants