Skip to content

Fix colorization of nested list.#19596

Merged
mjbvz merged 1 commit intomicrosoft:masterfrom
katainaka0503:fixColorizeNestedList
Feb 1, 2017
Merged

Fix colorization of nested list.#19596
mjbvz merged 1 commit intomicrosoft:masterfrom
katainaka0503:fixColorizeNestedList

Conversation

@katainaka0503
Copy link
Contributor

Fixed colorization of nested list with unindented line.
Previously, bullets of nested list with empty line above was not colored.

This change related to #19417 which updated markdown-it version,
and after applied that, two consecutive newlines no longer terminate a list.

This PR is modified one of #19559

@mention-bot
Copy link

@katainaka0503, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @rebornix to be potential reviewers.

@msftclas
Copy link

Hi @katainaka0503, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@katainaka0503
Copy link
Contributor Author

katainaka0503 commented Jan 30, 2017

I am not sure what 509th line and 510th in extensions/markdown/syntaxes/markdown.tmLanguage mean.

<key>comment</key>
<string>Currently does not support un-indented second lines.</string>

If this comment means this

- aaa
(empty line)
    - bbb
(empty line)
    - ccc

is not properly colored,
maybe this comment should be deleted.

(this was repost from #19596 )

Fixed colorization of nested list with unindented line.
@mjbvz mjbvz merged commit 96ba7c2 into microsoft:master Feb 1, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 1, 2017

Thanks for the contribution. This will be in the 1.10 vscode insiders builds once we start those up again

@mjbvz mjbvz added this to the February 2017 milestone Feb 1, 2017
@katainaka0503 katainaka0503 deleted the fixColorizeNestedList branch February 2, 2017 01:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants