I created https://github.com/gjsjohnmurray/vscode-extension-samples/tree/test-192009 with a modified source-control-sample extension that should add either a cloud-download or a cloud-upload action on a second resource group, with a click on the visible button toggling to the other one.

I think I worked out how to do this, so the PR is now ready for review.

@lszomoru please consider taking this before endgame.

@lszomoru please consider merging this for April.

Please accept this PR to close the linked issue, which is tagged help wanted.

@lszomoru please consider merging this for May.

@lszomoru I have updated this. Please consider taking it for July.

@lszomoru I have updated this from main, so it's ready for your review 🙏

56bdd9c

@lszomoru this is up to date with main and ready for your consideration again.

@gjsjohnmurray, thank you! It is on my list for this week...

@gjsjohnmurray, I have pushed couple of commits today to this PR in order to get it ready to merge.
I would really appreciate if you could take a look at the changes and validate them with your test extension. Thanks!

@lszomoru your most recent 2 commits seem to have broken my test (the modified sourec-control-sample). In it the FiddleSourceControl constructor has these two added lines:

		this.dummyGroup = this.jsFiddleScm.createResourceGroup('testing', 'Testing #192009');
		this.dummyGroup.contextValue = 'download';

When debugging this PR's branch after your latest commits I'm finding that the setting of dummyGroup.contextValue has no effect because it reaches $updateGroupContextValue in MainTrhreadSCMProvider before this._groupsByHandle has been populated. That's because $registerGroups of MainThreadSCM is called from eventuallyAddResourceGroups of ExtHostSourceControl, whose name indicates that it doesn't happen right away.

I'm guessing that reverting your last 2 commits will make my test work again, but I want to check with you first. I'd like to understand why you made those changes.

@gjsjohnmurray, thanks for testing the changes. The problem with setting the contextValue when creating the resource group on the "main side" is that you end up calling get contextValue() which throws so it breaks all extensions that does not have the proposal enabled.

I will take a look int the afternoon to see if I can fix the issue that you have discovered.

@gjsjohnmurray, pushed another commit. Could you please give it another try and let me know. Thanks!

@gjsjohnmurray, pushed another commit. Could you please give it another try and let me know. Thanks!

Nice! My test extension now works again. Looking forward to this merging, and I hope it won't need to wait many iterations before the API gets finalized.